Skip to content

reporting: fix forbidden/unregistered op reporting#2828

Merged
evans merged 2 commits into
masterfrom
evans/fix-registration-reporting
Jun 11, 2019
Merged

reporting: fix forbidden/unregistered op reporting#2828
evans merged 2 commits into
masterfrom
evans/fix-registration-reporting

Conversation

@evans

@evans evans commented Jun 11, 2019

Copy link
Copy Markdown
Contributor

Marking of operations as registered and forbidden in traces happens too early in the request pipeline, so this PR places the condition check at the end of the request

@evans evans requested a review from cheapsteak June 11, 2019 20:29

@cheapsteak cheapsteak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@evans evans merged commit aefe8ea into master Jun 11, 2019
@evans evans deleted the evans/fix-registration-reporting branch June 11, 2019 23:48
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants