Skip to content

Typing fixed for context function#2959

Merged
abernix merged 5 commits into
apollographql:masterfrom
stefanholzapfel:master
Jul 24, 2019
Merged

Typing fixed for context function#2959
abernix merged 5 commits into
apollographql:masterfrom
stefanholzapfel:master

Conversation

@stefanholzapfel

@stefanholzapfel stefanholzapfel commented Jul 1, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@apollo-cla

Copy link
Copy Markdown

@stefanholzapfel: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Comment thread packages/apollo-server-express/src/ApolloServer.ts Outdated
Comment thread packages/apollo-server-express/src/ApolloServer.ts Outdated
Co-Authored-By: Jesse Rosenberger <git@jro.cc>
@stefanholzapfel

Copy link
Copy Markdown
Contributor Author

Thanks for finding the ExecutionParams interface for me, was lazy on that :)

@Siyfion

Siyfion commented Jul 12, 2019

Copy link
Copy Markdown
Contributor

@stefanholzapfel / @abernix any idea of when we're likely to get this deployed/resolved? It's killing all our TypeScript builds rather nicely at the moment. 😭

@abernix abernix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@abernix abernix merged commit 1deffbe into apollographql:master Jul 24, 2019
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants