Skip to content

Remove excessive warning re graph variant #3043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abernix merged 4 commits into from
Jul 16, 2019
Merged

Remove excessive warning re graph variant #3043

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
928a703
Remove excessive warning re graph variant
Jul 16, 2019
b1bec1a
Merge branch 'master' into jackson/remove-excessive-logging
abernix Jul 16, 2019
b70a273
Add CHANGELOG.md for #3043.
abernix Jul 16, 2019
2fd7e8e
Merge branch 'master' into jackson/remove-excessive-logging
abernix Jul 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/apollo-gateway/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,12 @@ export class ApolloGateway implements GraphQLService {
}

public async load(options?: { engine?: GraphQLServiceEngineConfig }) {
if (options) this.engineConfig = options.engine;
if (options && options.engine) {
if (!options.engine.graphVariant)
console.warn('No graph variant provided. Defaulting to `current`.');
this.engineConfig = options.engine;
}

if (this.schema) {
return { schema: this.schema, executor: this.executor };
}
Expand Down
1 change: 0 additions & 1 deletion packages/apollo-gateway/src/loadServicesFromStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ export async function getServiceDefinitionsFromStorage({
const secret = await fetchStorageSecret(graphId, apiKeyHash);

if (!graphVariant) {
console.warn('No graphVariant specified, defaulting to "current".');
graphVariant = 'current';
}

Expand Down
⚡