apollo-engine-reporting: clean up SIGINT/SIGTERM handlers on stop#3090
Merged
Conversation
abernix
approved these changes
Jul 26, 2019
abernix
approved these changes
Jul 26, 2019
abernix
left a comment
abernix
left a comment
Member
There was a problem hiding this comment.
LGTM. A CHANGELOG.md would be great, but I can add it later too.
Member
Author
|
I don't understand how changelogging works for modules like apollo-engine-reporting that don't have lockstep versioning. Do I just stick it in vNEXT anyway and it'll get pulled in by some top level v2.7.2 release or whatever via dependencies? |
Among other things, this fixes logs in our test suite of 'Possible EventEmitter memory leak detected'.
glasser
force-pushed
the
glasser/signal-cleanup
branch
from
389c808 to
a29045d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Among other things, this fixes logs in our test suite of 'Possible EventEmitter
memory leak detected'.