Support older input formats for building a schema#3188
Merged
Conversation
typeDefs could be either an array of DocumentNodes or a single DocumenNode attached to an object with a possible resovler map. This shouldn't be supported in the next major version of ApolloServer when we have a more structured approach to modules, but for now this makes migration to federated services much easier for teams that have an existing set of typeDefs generated from their project (often in .graphql files).
jbaxleyiii
force-pushed
the
jbaxleyiii/buildFederateSchema-API
branch
from
8d9548e to
fa2aa6c
Compare
abernix
requested changes
Aug 23, 2019
abernix
left a comment
abernix
left a comment
Member
There was a problem hiding this comment.
I pushed two commits directly to this PR which I'm certain you won't find offensive, but I've left one remaining comment regarding the claim of this PR itself.
Otherwise, this looks great!
Co-Authored-By: Jesse Rosenberger <git@jro.cc>
Removing the extra letter from this variable necessitates changing all the things, apparently.
abernix
approved these changes
Aug 23, 2019
Member
|
Released in |
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…de[]`s only). (apollographql/apollo-server#3188) * Support older input formats for building a schema from typeDefs where typeDefs could be either an array of DocumentNodes or a single DocumenNode attached to an object with a possible resovler map. This shouldn't be supported in the next major version of ApolloServer when we have a more structured approach to modules, but for now this makes migration to federated services much easier for teams that have an existing set of typeDefs generated from their project (often in .graphql files). * Adjust spelling of variable. * Add period on end of sentence in CHANGELOG.md. * Update CHANGELOG.md Co-Authored-By: Jesse Rosenberger <git@jro.cc> * Oh Prettier, I'm coming for you. Removing the extra letter from this variable necessitates changing all the things, apparently. Apollo-Orig-Commit-AS: apollographql/apollo-server@8557e85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support older input formats for building a schema from
typeDefswheretypeDefscould be either an array ofDocumentNodes or a singleDocumenNodeattached to an object with a possible resolver map. This shouldn't be supported in the next major version ofApolloServerwhen we have a more structured approach to modules, but for now this makes migration to federated services much easier for teams that have an existing set oftypeDefsgenerated from their project (often in.graphqlfiles).