apollo-engine-reporting: direct path string building#3479
Merged
Conversation
pcarrier
changed the title
abernix
approved these changes
Nov 13, 2019
abernix
left a comment
abernix
left a comment
Member
There was a problem hiding this comment.
Good catch! I'm certain this would be more efficient.
I've left a couple comments within. This needs a - apollo-engine-reporting: CHANGELOG.md entry (which we'll add before merging if you don't have one in mind) and my only other firm ask is that we add the comment in-line for posterity's sake.
| } from 'graphql'; | ||
| import { Trace, google } from 'apollo-engine-reporting-protobuf'; | ||
| import { GraphQLError, GraphQLResolveInfo, ResponsePath } from 'graphql'; | ||
| import { google, Trace } from 'apollo-engine-reporting-protobuf'; |
Member
There was a problem hiding this comment.
Strongly prefer keeping these no-op, one-off changes out of change sets, but not asking you to revert it.
Member
|
(I low-key wish there were |
I don't know the difference :D Co-Authored-By: Jesse Rosenberger <git@jro.cc>
Thanks Co-Authored-By: Jesse Rosenberger <git@jro.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have performance numbers, but creating those arrays and reversing them could be worth avoiding.