Skip to content

Move TContext generic from requestDidStart method to ApolloServerPlugin Interface #3525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trevor-scheer merged 6 commits into from
Dec 9, 2019
Merged

Move TContext generic from requestDidStart method to ApolloServerPlugin Interface #3525

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e91029b
Move TContext generic from requestDidStart method to ApolloServerPlug…
jdmoody Nov 17, 2019
94b128c
Merge branch 'master' into master
jdmoody Nov 18, 2019
321630a
Merge branch 'master' into master
jdmoody Nov 22, 2019
7116697
Merge branch 'master' into master
jdmoody Nov 23, 2019
ccec577
Constrain TContext generic to match expected context shape
jdmoody Dec 6, 2019
0eda6d4
Merge branch 'master' into master
trevor-scheer Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/apollo-server-plugin-base/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ export {
WithRequired,
};

export interface ApolloServerPlugin {
export interface ApolloServerPlugin<TContext = Record<string, any>> {
Comment thread
jdmoody marked this conversation as resolved.
Outdated
serverWillStart?(service: GraphQLServiceContext): ValueOrPromise<void>;
requestDidStart?<TContext>(
requestDidStart?(
Comment thread
abernix marked this conversation as resolved.
requestContext: GraphQLRequestContext<TContext>,
): GraphQLRequestListener<TContext> | void;
}
Expand Down
⚡