Release 2.14.1#4175
Merged
Merged
Conversation
The `apollo-server-testing` package uses an internal Apollo Server method called `executeOperation` (introduced in [#1909]) in order to power its `createTestClient` functionality. This is the testing practice which is documented within [Integration testing] in the Apollo Server documentation. However, it failed to introduce the same context-cloning which [takes place in `runHttpQuery`][Ref 1], prior to arriving at the main request pipeline. Since the context was not cloned, and we had made the expectation in [#3988] that it was a unique context on every single request (which it was, in a non-testing context), the Symbol we use to implement `willResolveField` was already present [on the request pipeline][Ref 2] when running a subsequent test via `createTestClient`! This commit introduces the same cloning that takes place in `buildRequestContext` within `runHttpQuery`, and adds tests to ensure the behavior is preserved. [Fixes #4170]: #4170 [#1909]: #1909 [Integration testing]: https://www.apollographql.com/docs/apollo-server/testing/testing/ [Ref 1]: https://git.io/Jfou6 [#3988]: #3988 [Ref 2]: https://git.io/Jfouy
…-server into release-2.14.1
- @apollo/federation@0.16.2 - @apollo/gateway@0.16.2 - apollo-server-azure-functions@2.14.1 - apollo-server-cloud-functions@2.14.1 - apollo-server-cloudflare@2.14.1 - apollo-server-core@2.14.1 - apollo-server-express@2.14.1 - apollo-server-fastify@2.14.1 - apollo-server-hapi@2.14.1 - apollo-server-integration-testsuite@2.14.1 - apollo-server-koa@2.14.1 - apollo-server-lambda@2.14.1 - apollo-server-micro@2.14.1 - apollo-server-testing@2.14.1 - apollo-server@2.14.1
This was referenced Jun 6, 2020
abernix
added a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…l/release-2.14.1 Apollo-Orig-Commit-AS: apollographql/apollo-server@ab94135
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with release PRs in the past, this is a PR tracking a
release-2.14.1branch for an upcoming patch release of Apollo Server. 🙌 The version in the title of this PR should correspond to the appropriate branch.This, in particular, is a quick release to fix:
And to also land:
@requiresfields #4064