Allow schema reporting via environment variable#4206
Merged
Conversation
jsegaran
force-pushed
the
jsegaran/schema_report_env_var
branch
from
2d613cf to
7a7dbdd
Compare
zionts
reviewed
Jun 5, 2020
|
|
||
|
|
||
| if (options.experimental_schemaReporting !== undefined) { | ||
| this.schemaReport = options.experimental_schemaReporting; |
Contributor
There was a problem hiding this comment.
should we also add an options.schemaReporting as well and deprecate the old one, or do you want to do that in another PR?
Contributor
Author
There was a problem hiding this comment.
I'd rather deprecate the field in a different PR. I think it should be in 2.15
zionts
approved these changes
Jun 5, 2020
zionts
left a comment
zionts
left a comment
Contributor
There was a problem hiding this comment.
lgtm :) + wanna add the GM- ticket in the desc?
abernix
approved these changes
Jun 8, 2020
abernix
left a comment
abernix
left a comment
Member
There was a problem hiding this comment.
I think with a CHANGELOG.md, this is good to go!
jsegaran
force-pushed
the
jsegaran/schema_report_env_var
branch
from
65607b3 to
4c41abc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow enabling schema reporting via setting
APOLLO_SCHEMA_REPORTINGto true.