fix: Missing lru-cache dependency

[oliversalzburg]

signatureCache in usageReporting uses it, so it needs to be declared.

[abernix]

Thanks!

Ref: #4453

[glasser]

Does this break the use of v2.18 in some cases? Should I rush this out as a v2.18.2, since I think v2.19 is going to go out until next week due to @jsegaran 's schedule?

[oliversalzburg]

I noticed problems with this when using yarn2 with PnP. Those problems can be worked around though.

For completeness, this would locally resolve the issue through .yarnrc.yml:

packageExtensions:
  apollo-server-core@*:
    dependencies:
      lru-cache: "*"

Without that override, users may be unable to start Apollo server if an Apollo Studio API key is provided and schema reporting is enabled. In such a case, users will see the following error:

/home/oliver/fairmanager/backend/core-web3/.pnp.js:18150
  return Object.defineProperties(new Error(message), {
                                 ^

Error: apollo-server-core tried to access lru-cache, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: lru-cache (via "lru-cache")
Required by: apollo-server-core@virtual:2863b77f896288a34e8cf6e680a24e8a807ca93488044e012533af520a8f6ffbcfeecde8ba8d683ee29b1c135bd7e1600d758842f436d15d071668e1c246e3c5#npm:2.18.1 (via /home/oliver/fairmanager/backend/core-web3/.yarn/$$virtual/apollo-server-core-virtual-4e6dbc9000/0/cache/apollo-server-core-npm-2.18.1-9f020f54c3-68b6565dae.zip/node_modules/apollo-server-core/dist/plugin/usageReporting/)

Require stack:
- /home/oliver/fairmanager/backend/core-web3/.yarn/$$virtual/apollo-server-core-virtual-4e6dbc9000/0/cache/apollo-server-core-npm-2.18.1-9f020f54c3-68b6565dae.zip/node_modules/apollo-server-core/dist/plugin/usageReporting/signatureCache.js
- /home/oliver/fairmanager/backend/core-web3/.yarn/$$virtual/apollo-server-core-virtual-4e6dbc9000/0/cache/apollo-server-core-npm-2.18.1-9f020f54c3-68b6565dae.zip/node_modules/apollo-server-core/dist/plugin/usageReporting/plugin.js
- /home/oliver/fairmanager/backend/core-web3/.yarn/$$virtual/apollo-server-core-virtual-4e6dbc9000/0/cache/apollo-server-core-npm-2.18.1-9f020f54c3-68b6565dae.zip/node_modules/apollo-server-core/dist/plugin/usageReporting/index.js
- /home/oliver/fairmanager/backend/core-web3/.yarn/$$virtual/apollo-server-core-virtual-4e6dbc9000/0/cache/apollo-server-core-npm-2.18.1-9f020f54c3-68b6565dae.zip/node_modules/apollo-server-core/dist/plugin/index.js
- /home/oliver/fairmanager/backend/core-web3/.yarn/$$virtual/apollo-server-core-virtual-4e6dbc9000/0/cache/apollo-server-core-npm-2.18.1-9f020f54c3-68b6565dae.zip/node_modules/apollo-server-core/dist/ApolloServer.js
- /home/oliver/fairmanager/backend/core-web3/.yarn/$$virtual/apollo-server-core-virtual-4e6dbc9000/0/cache/apollo-server-core-npm-2.18.1-9f020f54c3-68b6565dae.zip/node_modules/apollo-server-core/dist/index.js
- /home/oliver/fairmanager/backend/core-web3/.yarn/$$virtual/apollo-server-koa-virtual-2863b77f89/0/cache/apollo-server-koa-npm-2.18.1-21cf2948f2-48849653d8.zip/node_modules/apollo-server-koa/dist/index.js
- /home/oliver/fairmanager/backend/core-web3/dist/plugins/QueryComplexityPlugin.js
- /home/oliver/fairmanager/backend/core-web3/dist/container/Application.js
- /home/oliver/fairmanager/backend/core-web3/dist/main.js
    at internalTools_makeError (/home/oliver/fairmanager/backend/core-web3/.pnp.js:18150:34)
    at resolveToUnqualified (/home/oliver/fairmanager/backend/core-web3/.pnp.js:19109:23)
    at resolveRequest (/home/oliver/fairmanager/backend/core-web3/.pnp.js:19201:29)
    at Object.resolveRequest (/home/oliver/fairmanager/backend/core-web3/.pnp.js:19279:26)
    at Function.external_module_.Module._resolveFilename (/home/oliver/fairmanager/backend/core-web3/.pnp.js:18383:34)
    at Function.external_module_.Module._load (/home/oliver/fairmanager/backend/core-web3/.pnp.js:18248:48)
    at Module.require (internal/modules/cjs/loader.js:974:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/home/oliver/fairmanager/backend/core-web3/.yarn/$$virtual/apollo-server-core-virtual-4e6dbc9000/0/cache/apollo-server-core-npm-2.18.1-9f020f54c3-68b6565dae.zip/node_modules/apollo-server-core/dist/plugin/usageReporting/signatureCache.js:7:37)
    at Module._compile (internal/modules/cjs/loader.js:1085:30)

Sorry for not providing the information initially. I was in a hurry :(

[glasser]

Thanks, see #4628