Resolve Issue #5724: parse all content types ending with +json as json in rest data source#5737
Merged
glasser merged 2 commits intoSep 29, 2021
Conversation
|
@nholik: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
Member
|
This looks good. It needs a CHANGELOG.md entry before it can be merged, which I can get to soon unless you do it first. (It's a little weird how we still have a single CHANGELOG.md file even though packages such as apollo-datasource-rest have unrelated versioning; I'd like to eventually move apollo-datasource-rest and apollo-datasource to its own repo as part of improving this.) |
…n +json as JSON rather than listing specific types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses issue 5724. It is a simple change to treat all content types ending with +json similar to how all content types beginning with application/json are automatically parsed as JSON. The helps cover some other common types of JSON types beyond the original hard coded exception.