Skip to content

fix(fastify): use scoped modules#6366

Merged
glasser merged 1 commit into
apollographql:mainfrom
SimenB:fastify-scoped
May 5, 2022
Merged

fix(fastify): use scoped modules#6366
glasser merged 1 commit into
apollographql:mainfrom
SimenB:fastify-scoped

Conversation

@SimenB

@SimenB SimenB commented Apr 28, 2022

Copy link
Copy Markdown
Contributor

The official plugins of fastify are now scoped, and the old names are deprecated. There should be no other breaking changes.

@netlify

netlify Bot commented Apr 28, 2022

Copy link
Copy Markdown

👷 Deploy request for apollo-server-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 55219f5

@codesandbox-ci

codesandbox-ci Bot commented Apr 28, 2022

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 55219f5:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

@glasser

glasser commented May 4, 2022

Copy link
Copy Markdown
Member

@SimenB Just to check: are the new packages fully backwards compatible with the old ones (eg, can you use the accepts and cors middlewares from the new packages with the same versions of Fastify as before?), or will users upgrading to a newer version of apollo-server-fastify need to upgrade Fastify as well?

(For what it's worth, we will be solving this problem in Apollo Server 4 by not trying to magically wrap these middleware in our own middleware and trusting that (with clearly documented examples) folks can use these middleware directly. We will also be decoupling the apollo-server-fastify release process from the Apollo Server core release process by providing a stable API between ApolloServer and web framework integrations and allowing active users of web frameworks like Fastify to maintain the integration with their expertise.)

@SimenB

SimenB commented May 4, 2022

Copy link
Copy Markdown
Contributor Author

Yeah, only breaking change is the rename 🙂

@glasser

glasser commented May 4, 2022

Copy link
Copy Markdown
Member

Great. Mind resolving the package-lock.json conflict? Rebasing should clear up the spell-check failure too.

@SimenB SimenB force-pushed the fastify-scoped branch from 8d988ad to 55219f5 Compare May 5, 2022 05:13
@SimenB

SimenB commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

@glasser done 🙂

@glasser

glasser commented May 5, 2022

Copy link
Copy Markdown
Member

Thanks! I'll put this out in apollo-server-fastify@3.6.8 today.

@glasser glasser merged commit 45f09fa into apollographql:main May 5, 2022
@SimenB SimenB deleted the fastify-scoped branch May 5, 2022 16:35
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants