Remove caching packages#6541
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3e2c0f9:
|
glasser
approved these changes
Jun 8, 2022
glasser
left a comment
glasser
left a comment
Member
There was a problem hiding this comment.
Perhaps PR description should note that the contents of apollo-server-caching have migrated (roughly, with a change to boundedness of InMemory) to the utils package
trevor-scheer
added a commit
that referenced
this pull request
Jun 15, 2022
Remove apollo-server-caching, apollo-server-cache-redis, and apollo-server-cache-memcached packages. We will continue to offer bugfixes for these packages as needed but don't intend to continue active development on them. Our recommendation going forward will be to use the keyv package along with our KeyvAdapter from the @apollo/utils.keyvadapter package. Docs updates to come in a following PR (but coupled with this release). The KeyValueCache interface and InMemoryLRUCache wrapper around lru-cache (as well as a few useful cache wrappers like PrefixingKeyValueCache) will continue to exist in the @apollo/utils.keyvaluecache package. It's worth mentioning that InMemoryLRUCache is on a newer major version of lru-cache which doesn't permit the unbounded behavior which we've had by default. In AS 3.9 you can opt into the bounded cache, and in AS4 it will be the default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
apollo-server-caching,apollo-server-cache-redis, andapollo-server-cache-memcachedpackages. We will continue to offer bugfixes for these packages as needed but don't intend to continue active development on them. Our recommendation going forward will be to use thekeyvpackage along with ourKeyvAdapterfrom the@apollo/utils.keyvadapterpackage. Docs updates to come in a following PR (but coupled with this release).The
KeyValueCacheinterface andInMemoryLRUCachewrapper aroundlru-cache(as well as a few useful cache wrappers likePrefixingKeyValueCache) will continue to exist in the@apollo/utils.keyvaluecachepackage. It's worth mentioning thatInMemoryLRUCacheis on a newer major version oflru-cachewhich doesn't permit the unbounded behavior which we've had by default. In AS 3.9 you can opt into the bounded cache, and in AS4 it will be the default.