Rename property for RESTDataSource#6834
Conversation
✅ Deploy Preview for apollo-server-docs canceled.Built without sensitive environment variables
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4671b57:
|
glasser
left a comment
glasser
left a comment
There was a problem hiding this comment.
revert CHANGELOG and I'll merge.
Your previous PR was a great step in the right direction of actually explaining what RESTDataSource does in its doc page. I know @rkoron007 will be looking at that page soon and perhaps that can be an opportunity to add an overall explanation of the caching behavior and expected lifecycle on the page (the general concept of “create a RESTDataSource once per request; all GET requests are memoized inside the data source regardless of HTTP cache control headers in the response; also the shared cache is used to cache anything with HTTP cache control headers in a way that honors the headers”). That the page doesn't mention anywhere that each RDS object is per request is pretty silly.
Rename property for RESTDataSource from requestCacheEnabled to memoizeGetRequests From the initial PR, the name of the new property was a little confusing since there are actually two caches, but what is being cached is the response data in the end. Original PR #3 Back-port of apollographql/apollo-server#6834
2 participants
Rename property for RESTDataSource from
requestCacheEnabledtomemoizeGetRequestsFrom the initial PR, the name of the new property was a little confusing since there are actually two caches, but what is being cached is the response data in the end
Original PR #6650