Add Jest imports everywhere, remove global availability#6911
Merged
trevor-scheer merged 3 commits intoversion-4from Sep 15, 2022
Merged
Add Jest imports everywhere, remove global availability#6911trevor-scheer merged 3 commits intoversion-4from
trevor-scheer merged 3 commits intoversion-4from
Conversation
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 82a4ab6:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ESM mode, the
jestglobals are technically no longer available. For some reason, we're still getting away with it, but this issue surfaces in the v29 upgrade PR so I'm going to address it separately.https://jestjs.io/docs/ecmascript-modules#differences-between-esm-and-commonjs
Ref: #6850 (comment)