Fix apollo-server-core runQuery breaks async_hook tracking#733
Merged
Conversation
|
@domarmstrong: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
By creating a promise out of the execution flow the ability to trace the async call stack is lost.
Contributor
|
Thanks! |
abernix
added a commit
to dandean/apollo-server
that referenced
this pull request
Mar 26, 2018
abernix
added a commit
that referenced
this pull request
Mar 26, 2018
This was referenced Mar 26, 2018
Closed
CaptainJojo
pushed a commit
to CaptainJojo/apollo-server
that referenced
this pull request
Apr 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By creating a promise out of the execution flow the ability to trace the
async call stack is lost.
TODO: