Skip to content

Inline all possible functions that are used only once#821

Merged
abernix merged 5 commits into
apollographql:masterfrom
marvinhagemeister:faster_fn
Mar 12, 2018
Merged

Inline all possible functions that are used only once#821
abernix merged 5 commits into
apollographql:masterfrom
marvinhagemeister:faster_fn

Conversation

@marvinhagemeister

@marvinhagemeister marvinhagemeister commented Feb 11, 2018

Copy link
Copy Markdown
Contributor
  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

This PR contributes the following changes:

  • Inline both isFunction and isOptionsFunction which are only ever used once.
  • Move printStackTrace and format out of doRunQuery so that they are not recreated each time doRunQuery is called

@apollo-cla

Copy link
Copy Markdown

@marvinhagemeister: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants