Tighter context typing for GraphQLServerOptions#919
Merged
abernix merged 2 commits intoApr 18, 2018
Conversation
|
@majelbstoat: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
Member
|
Sorry, apparently CircleCI wasn't setup to build PRs from Git forks. I think I've fixed it. Could perform either of the following?:
(Both of these assume that your |
3e0e465 to
c6ac66d
Compare
abernix
added a commit
that referenced
this pull request
Apr 18, 2018
Member
|
Thanks so much, @majelbstoat. |
Member
|
This should be published in |
Contributor
Author
|
Works great, thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small patch adds optional support for tighter typing on the context of GraphQLServerOptions, to match the equivalent ones in graphql-tools. There's still a gap as
GraphQLSchemaConfig,GraphQLObjectTypeandgetFieldsare all still typed asany, but it at least allows a demonstration of consistency between the resolvers passed to makeExecutableSchema and the context that will be supplied by parameterising them both with a common type. The param defaults to any and is backwards compatible.TODO:
/label types