Update federated service:check output (#1193)

* Fix pluralize function
* Update schema:check --federated output

Author: trevor-scheer

package-lock.json

@@ -13,7 +13,7 @@ export const CHECK_PARTIAL_SCHEMA = gql`
         implementingServiceName: $implementingServiceName
         partialSchema: $partialSchema
       ) {
-        compositionConfig {
+        compositionValidationDetails {
           schemaHash
         }
         errors {
@@ -22,7 +22,6 @@ export const CHECK_PARTIAL_SCHEMA = gql`
         warnings {
           message
         }
-        didUpdateGateway: updatedGateway
       }
     }
   }

packages/apollo-language-server/src/engine/operations/checkPartialSchema.ts

@@ -6,8 +6,8 @@
 // GraphQL mutation operation: CheckPartialSchema
 // ====================================================
 
-export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_compositionConfig {
-  __typename: "CompositionConfig";
+export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_compositionValidationDetails {
+  __typename: "CompositionValidationDetails";
   /**
    * Hash of the composed schema
    */
@@ -25,11 +25,13 @@ export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingS
 }
 
 export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph {
-  __typename: "CompositionResult";
+  __typename: "CompositionValidationResult";
   /**
-   * The produced composition config. Will be null if there are any errors
+   * Akin to a composition config, represents the partial schemas and implementing services that were used
+   * in running composition. Will be null if any errors are encountered. Also may contain a schema hash if
+   * one could be computed, which can be used for schema validation.
    */
-  compositionConfig: CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_compositionConfig | null;
+  compositionValidationDetails: CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_compositionValidationDetails | null;
   /**
    * List of errors during composition. Errors mean that Apollo was unable to compose the
    * graph's implementing services into a GraphQL schema. This partial schema should not be
@@ -44,10 +46,6 @@ export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingS
    * in its composition result will result in updating the composition config.
    */
   warnings: (CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_warnings | null)[];
-  /**
-   * Whether the gateway link was updated.
-   */
-  didUpdateGateway: boolean;
 }
 
 export interface CheckPartialSchema_service {

packages/apollo-language-server/src/graphqlTypes.ts

@@ -60,6 +60,7 @@
     "heroku-cli-util": "8.0.11",
     "listr": "0.14.3",
     "lodash": "4.17.11",
+    "strip-ansi": "5.2.0",
     "tty": "1.0.1",
     "vscode-uri": "1.0.6"
   },