Skip to content

Update federated service:check output#1193

Merged
JakeDawkins merged 2 commits intorelease-federationfrom
trevor/update-check-output
Apr 16, 2019
Merged

Update federated service:check output#1193
JakeDawkins merged 2 commits intorelease-federationfrom
trevor/update-check-output

Conversation

@trevor-scheer
Copy link
Copy Markdown
Contributor

@trevor-scheer trevor-scheer commented Apr 15, 2019

The purpose of this PR is to update how we display output from the federated service:check command. The style of this output resembles recent updates to the output of the standard service:check command.

image

image

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins
Copy link
Copy Markdown
Contributor

this are good

@JakeDawkins JakeDawkins merged commit 8013a0f into release-federation Apr 16, 2019
@JakeDawkins JakeDawkins deleted the trevor/update-check-output branch April 16, 2019 00:32
trevor-scheer added a commit that referenced this pull request May 9, 2019
* Fix pluralize function
* Update schema:check --federated output
trevor-scheer added a commit that referenced this pull request May 9, 2019
* Fix pluralize function
* Update schema:check --federated output
trevor-scheer added a commit that referenced this pull request May 9, 2019
* Fix pluralize function
* Update schema:check --federated output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants