Skip to content

Update federated service:check output #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakeDawkins merged 2 commits into from
Apr 16, 2019
Merged

Update federated service:check output #1193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0e5019
Fix pluralize function
trevor-scheer Apr 15, 2019
0c69d11
Update schema:check --federated output
trevor-scheer Apr 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions packages/apollo-language-server/src/engine/operations/checkPartialSchema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const CHECK_PARTIAL_SCHEMA = gql`
implementingServiceName: $implementingServiceName
partialSchema: $partialSchema
) {
compositionConfig {
compositionValidationDetails {
schemaHash
}
errors {
Expand All @@ -22,7 +22,6 @@ export const CHECK_PARTIAL_SCHEMA = gql`
warnings {
message
}
didUpdateGateway: updatedGateway
}
}
}
Expand Down
16 changes: 7 additions & 9 deletions packages/apollo-language-server/src/graphqlTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
// GraphQL mutation operation: CheckPartialSchema
// ====================================================

export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_compositionConfig {
__typename: "CompositionConfig";
export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_compositionValidationDetails {
__typename: "CompositionValidationDetails";
/**
* Hash of the composed schema
*/
Expand All @@ -25,11 +25,13 @@ export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingS
}

export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph {
__typename: "CompositionResult";
__typename: "CompositionValidationResult";
/**
* The produced composition config. Will be null if there are any errors
* Akin to a composition config, represents the partial schemas and implementing services that were used
* in running composition. Will be null if any errors are encountered. Also may contain a schema hash if
* one could be computed, which can be used for schema validation.
*/
compositionConfig: CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_compositionConfig | null;
compositionValidationDetails: CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_compositionValidationDetails | null;
/**
* List of errors during composition. Errors mean that Apollo was unable to compose the
* graph's implementing services into a GraphQL schema. This partial schema should not be
Expand All @@ -44,10 +46,6 @@ export interface CheckPartialSchema_service_validatePartialSchemaOfImplementingS
* in its composition result will result in updating the composition config.
*/
warnings: (CheckPartialSchema_service_validatePartialSchemaOfImplementingServiceAgainstGraph_warnings | null)[];
/**
* Whether the gateway link was updated.
*/
didUpdateGateway: boolean;
}

export interface CheckPartialSchema_service {
Expand Down
1 change: 1 addition & 0 deletions packages/apollo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
"heroku-cli-util": "8.0.11",
"listr": "0.14.3",
"lodash": "4.17.11",
"strip-ansi": "5.2.0",
"tty": "1.0.1",
"vscode-uri": "1.0.6"
},
Expand Down
Loading
⚡