Commit 3a6b11a
Use reference-equality when filtering rules in
Use object equality when filtering rules in `buildSchemaFromSDL`
Similar in spirit to apollographql/apollo-server#3338.
The technique previously used for removing rules from the standard
`specifiedRules` was leveraging a check on `Function.prototype.name`, rather
than doing direct object equality. While that does generally work, thanks
to the more recent standardization of `Function.prototype.name`, it still
breaks down under some of the more aggressive minification techniques since
a function's name is not guaranteed to remain the same.
Fixes: apollographql/apollo-server#3335buildSchemaFromSDL (#1551)1 parent fcdebb9 commit 3a6b11a
2 files changed
Lines changed: 12 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
28 | 35 | | |
29 | 36 | | |
30 | 37 | | |
| |||
33 | 40 | | |
34 | 41 | | |
35 | 42 | | |
36 | | - | |
37 | | - | |
38 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
39 | 46 | | |
40 | 47 | | |
41 | 48 | | |
42 | | - | |
| 49 | + | |
43 | 50 | | |
44 | 51 | | |
45 | 52 | | |
| |||
0 commit comments