Skip to content

Commit 809c027

Browse files
Don't swallow errors from Engine (#705)
* Don't swallow errors from Engine Throw errors we receive from Engine so we can provide the right feedback to users and handle the errors. * error.message is already a string, don't interpolate Fixes #701
1 parent 8169dc1 commit 809c027

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

  • packages/apollo-language-server/src/engine

packages/apollo-language-server/src/engine/index.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,9 @@ export class ApolloEngineClient extends GraphQLDataSource {
130130
);
131131
}
132132
// use error logger
133-
// if (errors) {
134-
// throw new Error(errors);
135-
// }
133+
if (errors) {
134+
throw new Error(errors.map(error => error.message).join("\n"));
135+
}
136136
if (!data) {
137137
throw new Error("Error in request from Engine");
138138
}
@@ -151,9 +151,9 @@ export class ApolloEngineClient extends GraphQLDataSource {
151151
);
152152
}
153153
// use error logger
154-
// if (errors) {
155-
// throw new Error(errors);
156-
// }
154+
if (errors) {
155+
throw new Error(errors.map(error => error.message).join("\n"));
156+
}
157157
if (!data) {
158158
throw new Error("Error in request from Engine");
159159
}
@@ -170,9 +170,9 @@ export class ApolloEngineClient extends GraphQLDataSource {
170170
);
171171
}
172172
// use error logger
173-
// if (errors) {
174-
// throw new Error(errors);
175-
// }
173+
if (errors) {
174+
throw new Error(errors.map(error => error.message).join("\n"));
175+
}
176176
if (!data) {
177177
throw new Error("Error in request from Engine");
178178
}
@@ -190,9 +190,9 @@ export class ApolloEngineClient extends GraphQLDataSource {
190190
);
191191
}
192192
// use error logger
193-
// if (errors) {
194-
// throw new Error(errors);
195-
// }
193+
if (errors) {
194+
throw new Error(errors.map(error => error.message).join("\n"));
195+
}
196196
if (!data) {
197197
throw new Error("Error in request from Engine");
198198
}

0 commit comments

Comments
 (0)