Command line apollo client:codegen command fails on npm install for TTY package

[jonathanpeterwu]

Intended outcome:

Attempting to use the apollo codegen command fails on TTY usage

Code patch PR

Remove TTY

yarn dlx --quiet apollo client:codegen
--localSchemaFile=./packages/site-builder/src/generated/schema.graphql
--target=typescript
--customScalarsPrefix=Api
--passthroughCustomScalars
_generated

Actual outcome:

Codegen command fails:

/tmp/xfs-69aa0038/dlx-2367/node_modules/cli-ux/lib/styled/table.js:285
columns: command_1.flags.string({ exclusive: ['extended'], description: 'only show provided columns (comma-separated)' }),
^

TypeError: Cannot read property 'string' of undefined
at /tmp/xfs-69aa0038/dlx-2367/node_modules/cli-ux/lib/styled/table.js:285:34
at Object. (/tmp/xfs-69aa0038/dlx-2367/node_modules/cli-ux/lib/styled/table.js:314:3)
at Module._compile (internal/modules/cjs/loader.js:1085:14)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
at Module.load (internal/modules/cjs/loader.js:950:32)
at Function.Module._load (internal/modules/cjs/loader.js:790:14)
at Module.require (internal/modules/cjs/loader.js:974:19)
at require (internal/modules/cjs/helpers.js:92:18)
at Object. (/tmp/xfs-69aa0038/dlx-2367/node_modules/cli-ux/lib/index.js:14:36)
at Module._compile (internal/modules/cjs/loader.js:1085:14)
make: *** [Makefile:177: packages/site-builder/src/generated/graphql-types.ts] Error 1

How to reproduce the issue:

To produce run apollo client:codegen from a fresh npm build download with your local TTY dependency removed

[enk0de]

Same problem +1
I am using Yarn 3 (up to berry)

[abernix]

Closed by #2406

[ladisalves]

It is still reproducible on version 2.33.6.

[nephix]

Can confirm, still exact same issue in 2.33.6. Can this be reopened?

npx apollo client:codegen --target=typescript --includes=packages/xxx/src/data/**/*.ts --tagName=gql --addTypename --outputFlat packages/xxx/src/data/_types --endpoint http://localhost:3000/graphql --passthroughCustomScalars

xxx/node_modules/cli-ux/lib/styled/table.js:285
        columns: command_1.flags.string({ exclusive: ['extended'], description: 'only show provided columns (comma-separated)' }),
                                 ^

TypeError: Cannot read properties of undefined (reading 'string')
    at xxx/node_modules/cli-ux/lib/styled/table.js:285:34
    at Object.<anonymous> (xxx/node_modules/cli-ux/lib/styled/table.js:314:3)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:94:18)
    at Object.<anonymous> (xxx/node_modules/cli-ux/lib/index.js:14:36)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)

When I run the command from zsh directly, I get:

$ npx apollo client:codegen --target=typescript --includes=packages/mobile/src/data/**/*.ts --tagName=gql --addTypename --outputFlat packages/mobile/src/data/_types --endpoint http://localhost:3000/graphql --passthroughCustomScalars

zsh: no matches found: --includes=packages/mobile/src/data/**/*.ts

Paths are correct and it worked before

[ladisalves]

It seems it is already merged but it is not in the last build. Just run the build...

[nephix]

@ladisalves are you sure? I just checked the diff between releases and it looks like the changes of #2406 are included:

https://github.com/apollographql/apollo-tooling/compare/apollo%402.33.5...apollo@2.33.6

[ladisalves]

@ladisalves are you sure? I just checked the diff between releases and it looks like the changes of #2406 are included:

https://github.com/apollographql/apollo-tooling/compare/apollo%402.33.5...apollo@2.33.6

Yep, you are right. I was confused because tty is still dependecy in package.json.

[nephix]

Nobody else encountering this? I use the same command in a project that uses yarn instead of npm and there it still seems to work

[nephix]

I've switched to @graphql-codegen/cli and it's a very good alternative