Skip to content

Breaking changes in transition from flow-modern to flow #469

@mike-marcacci

Description

@mike-marcacci

There appear to be several big changes in the way the previously-named "flow-modern" generator works:

  1. The latest version of apollo on NPM generates .ts files (this is fixed in master by 9cc628c but should probably be pushed ASAP)
  2. The generated files are no longer put in a __generated__ directory, which breaks all existing imports, tooling configs (eslint, prettier, etc), and risks clobbering non-generated source files.

Is the latter intentional? If so, we definitely need a CLI option to add it back; if not, then we should fix this ASAP.

If somebody at Apollo can point me on one of those directions, I'll have a PR up 5 minutes later! (I'm trying to move off my fork right now.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions