Remove defaults from historic validation#1006
Merged
trevor-scheer merged 2 commits intomasterfrom Feb 11, 2019
Merged
Conversation
Previous behavior leveraged the nullability of the checkSchema mutation. By removing defaults from the flags, we can expect behavior to be the same as it was before when no historic flags are provided.
JakeDawkins
approved these changes
Feb 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous behavior leveraged the nullability of the checkSchema mutation. By removing defaults from the flags, we can expect the same behavior as before when no historic flags are provided.
What's incorrect?
Defaulting to one day for the period was an incorrect assumption on my part - this value can vary on the backend when it's not provided, depending on the user's plan. To account for this, we need the option to provide nothing in the way of historical params (as we were doing before).
TODO: