Skip to content

[AT-58] Use generated Typescript types#1016

Merged
trevor-scheer merged 12 commits intomasterfrom
trevor/codegen-on-itself
Feb 27, 2019
Merged

[AT-58] Use generated Typescript types#1016
trevor-scheer merged 12 commits intomasterfrom
trevor/codegen-on-itself

Conversation

@trevor-scheer
Copy link
Copy Markdown
Contributor

@trevor-scheer trevor-scheer commented Feb 13, 2019

This PR serves a couple purposes:

  1. Get more reliable Typescript types by using code generation and CI to ensure our types stay up to date with our schema
  2. Dogfood codegen (on its own codebase 😄)

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@trevor-scheer trevor-scheer force-pushed the trevor/codegen-on-itself branch from 596bada to cdcf51c Compare February 27, 2019 21:43
@trevor-scheer trevor-scheer changed the title [WIP] Use generated Typescript types Use generated Typescript types Feb 27, 2019
@trevor-scheer trevor-scheer force-pushed the trevor/codegen-on-itself branch from d8fc2af to 90ba416 Compare February 27, 2019 22:23
@trevor-scheer trevor-scheer merged commit 2be71f4 into master Feb 27, 2019
@trevor-scheer trevor-scheer deleted the trevor/codegen-on-itself branch February 27, 2019 23:37
@trevor-scheer trevor-scheer changed the title Use generated Typescript types [AT-58] Use generated Typescript types Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant