Skip to content

Add eslint-disable to generated files#1017

Merged
trevor-scheer merged 4 commits intoapollographql:masterfrom
adrienharnay:patch-1
Feb 13, 2019
Merged

Add eslint-disable to generated files#1017
trevor-scheer merged 4 commits intoapollographql:masterfrom
adrienharnay:patch-1

Conversation

@adrienharnay
Copy link
Copy Markdown
Contributor

@adrienharnay adrienharnay commented Feb 13, 2019

tslint is disabled, but eslint is not (yet)

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

tslint is disabled, but eslint is not (yet)
@apollo-cla
Copy link
Copy Markdown

@adrienharnay: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@adrienharnay
Copy link
Copy Markdown
Contributor Author

Solves part of #1004

@trevor-scheer
Copy link
Copy Markdown
Contributor

This is great, thanks @adrienharnay!

@trevor-scheer trevor-scheer merged commit 6cbbe54 into apollographql:master Feb 13, 2019
@adrienharnay adrienharnay deleted the patch-1 branch February 13, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants