Add tests for config file loader util#1059
Merged
JakeDawkins merged 5 commits intomasterfrom Apr 1, 2019
Merged
Conversation
877e953 to
50cc697
Compare
trevor-scheer
approved these changes
Mar 27, 2019
79e098e to
7f7cb38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
What I did
apollo.config.js.apollo client:check --config=config/apollo.jswould also load./apollo.config.jsif it couldn't find the specified config. I think if a user is manually specifying a config, it should only load what they specified and throw an error if not found.getSearchPlacesfunction. It was extraneous, and misleading. Whilesearch placesis the term that dotenv uses, it is less descriptive thandefaultFileNames, since that what the search places are–filenames.try/catcharound the cosmiconfig's loader, since it can throw on malformed files with an unhelpful error..envis not aFile, but a folder or something else. Resolves apollo service:push fails because it makes assumptions about the environment #1132TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.