Remove the default --tag flag from client commands#1062
Merged
JakeDawkins merged 4 commits intomasterfrom Mar 4, 2019
Merged
Conversation
trevor-scheer
approved these changes
Mar 2, 2019
Contributor
|
Woo generated type check! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client:codegenwas defaulting to--tag=currentwhen not specifying a flag. That's because there was a default set. It didn't matter if you set another tag in your config, because the CLI flags took precedence over any other configs.This PR just removes the default flag, not the default tag. Hopefully this should be non-breaking in any way since the
currenttag fallback is already set other places as a last-resort item.fallbacks:
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.