Skip to content

Remove the default --tag flag from client commands#1062

Merged
JakeDawkins merged 4 commits intomasterfrom
jake/remove-default-tag
Mar 4, 2019
Merged

Remove the default --tag flag from client commands#1062
JakeDawkins merged 4 commits intomasterfrom
jake/remove-default-tag

Conversation

@JakeDawkins
Copy link
Copy Markdown
Contributor

@JakeDawkins JakeDawkins commented Feb 28, 2019

client:codegen was defaulting to --tag=current when not specifying a flag. That's because there was a default set. It didn't matter if you set another tag in your config, because the CLI flags took precedence over any other configs.

This PR just removes the default flag, not the default tag. Hopefully this should be non-breaking in any way since the current tag fallback is already set other places as a last-resort item.

fallbacks:

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@trevor-scheer
Copy link
Copy Markdown
Contributor

Woo generated type check!

@JakeDawkins JakeDawkins merged commit 80a715d into master Mar 4, 2019
@JakeDawkins JakeDawkins deleted the jake/remove-default-tag branch March 4, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants