Skip to content

Add missing dependencies "@babel/generator", "common-tags"#1071

Merged
trevor-scheer merged 2 commits intoapollographql:masterfrom
elliottsj:fix-deps
Mar 5, 2019
Merged

Add missing dependencies "@babel/generator", "common-tags"#1071
trevor-scheer merged 2 commits intoapollographql:masterfrom
elliottsj:fix-deps

Conversation

@elliottsj
Copy link
Copy Markdown
Contributor

@elliottsj elliottsj commented Mar 4, 2019

Fixes #1070

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@trevor-scheer
Copy link
Copy Markdown
Contributor

trevor-scheer commented Mar 4, 2019

@elliottsj it looks like this issue exists in the other codegen packages as well (I see scala, TS, and swift importing from common-tags). Would you mind adding to those as well?

Also see @babel/generator is imported in the TS generator package.

Thanks for taking care of these!

@elliottsj elliottsj force-pushed the fix-deps branch 3 times, most recently from 041de7c to 91a9033 Compare March 5, 2019 16:07
@elliottsj
Copy link
Copy Markdown
Contributor Author

Done!

@trevor-scheer trevor-scheer merged commit 0565165 into apollographql:master Mar 5, 2019
@trevor-scheer
Copy link
Copy Markdown
Contributor

Thanks so much!

@elliottsj elliottsj deleted the fix-deps branch March 6, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants