Expand peer dependency range of apollo-graphql to include 0.12.x and 0.13.x.#1076
Merged
trevor-scheer merged 5 commits intoapollographql:masterfrom Mar 5, 2019
Merged
Conversation
|
@patdmc: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
patdmc
changed the title
…de 0.12.x. This further expands upon @patdmc's expansion of the `graphql` peer dependency to also include the `0.12.x` versions as well, thus matching precisely with that of `apollo-server-core`: https://github.com/apollographql/apollo-server/blob/17257a2f097e3e84892426c1e78dc819e67117ad/packages/apollo-server-core/package.json#L48-L50 Since this package is depended on by `apollo-engine-reporting`, which is depended on by `apollo-server-core`, we should completely align the desired `graphql` version requirements until the time comes where we make the same reduction in the `graphql` peer dependency range within `apollo-server-core`: While that time will come soon, it's not here yet.
abernix
changed the title
apollo-graphql to include 0.12.x and 0.13.x.
abernix
approved these changes
Mar 5, 2019
Member
abernix
left a comment
abernix
left a comment
There was a problem hiding this comment.
I've added a follow-up commit (894733e
) which also includes 0.12.x, in accordance with the range specified by apollo-server-core, which relies on this package.
LGTM! And thanks!
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.