Document engine requirements in client:check and client:push#1077
Merged
JakeDawkins merged 2 commits intomasterfrom May 13, 2019
Merged
Document engine requirements in client:check and client:push#1077JakeDawkins merged 2 commits intomasterfrom
JakeDawkins merged 2 commits intomasterfrom
Conversation
JakeDawkins
force-pushed
the
jake/engine-req
branch
from
989bdbf to
27a4761
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from #1075
Previously, there was no explicit message stating that engine is a requirement for
client:checkandclient:pushcommands.It'd be easy to mistake these commands as ones that could be run with a
client.service.urlorlocalSchemaFile.TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.