Conversation
1) Remove duplication from client:push and client:extract. 2) Create a test to verify upcoming changes for this PR.
* Add apollo-graphql as a dependency (and project reference) * Remove apollo-engine-reporting as a dependency * Update sortAST to normalize order of fragments w.r.t operations * Tests are failing expectedly at this point
These two operations will likely be used in tandem, and we want this to be consistent across consumers. Incorporate rename suggestions Update version for extracted manifest output. Use empty string and add comment about unused metadata field. Revert changes to defaultEngineReportingSignature. Apply changes to new function, defaultOperationRegistrySignature. This new function is the effective interim fix, and the current existing function is now left alone.
…ation Interim Operation Normalization Fix
Pass operation name to the operation registry signature function
Now that registerOperations supports version as an argument to the mutation, we can leverage this for v2 oeprations manifest work.
- apollo-codegen-core@0.32.11-alpha.0 - apollo-codegen-flow@0.32.11-alpha.0 - apollo-codegen-scala@0.33.7-alpha.0 - apollo-codegen-swift@0.32.11-alpha.0 - apollo-codegen-typescript@0.32.12-alpha.0 - apollo-language-server@1.5.5-alpha.0 - apollo@3.0.0-alpha.2 - vscode-apollo@1.5.6-alpha.0
Contributor
|
Closing until we have actionable 3.0 plans |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR (and its associated
release-apollo-3.xbranch) will act as a staging branch for changes that are considered major breaking changes of theapolloCLI and will be released in a major version bump.This will allow work on the
masterbranch to continue uninterrupted and allow us to ship important fixes, like the fix to operation normalization in #1027 which are relevant to other parts of the Apollo Platform, immediately.Periodically, this
release-apollo-3.xbranch should be updated with work from themasterbranch by:Dev Note
Additional releases on this PR should be able to be published with:
$ npm run release -- prerelease \ --preid alpha \ --dist-tag alpha \ --include-merged-tags # this is important!