Skip to content

Add --localSchemaFile to service:check#1116

Merged
JakeDawkins merged 5 commits intoapollographql:masterfrom
fsouza:service-check-local-schema-file
Apr 23, 2019
Merged

Add --localSchemaFile to service:check#1116
JakeDawkins merged 5 commits intoapollographql:masterfrom
fsouza:service-check-local-schema-file

Conversation

@fsouza
Copy link
Copy Markdown
Contributor

@fsouza fsouza commented Mar 13, 2019

Fix #716.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@apollo-cla
Copy link
Copy Markdown

@fsouza: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@fsouza
Copy link
Copy Markdown
Contributor Author

fsouza commented Mar 13, 2019

Re: tests, if the approach looks correct, I can take a look at adding tests for service:check and the change.

@JakeDawkins JakeDawkins merged commit b199fea into apollographql:master Apr 23, 2019
@JakeDawkins
Copy link
Copy Markdown
Contributor

@fsouza thanks for this! I have another PR open right now re-enabling some old disabled tests, so I'll add the test for this flag there (#1198)

@fsouza fsouza deleted the service-check-local-schema-file branch April 23, 2019 14:27
@fsouza
Copy link
Copy Markdown
Contributor Author

fsouza commented Apr 23, 2019

@JakeDawkins sounds good, thanks for merging it! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

service:check should support --localSchemaFile

3 participants