apollo: fix remoteUrl in service:check [UI-258]#1121
Merged
Conversation
evans
force-pushed
the
evans/fix-remoteUrl
branch
from
d2dfca9 to
6282caa
Compare
The remoteUrl can no longer be the slug, since we can't assume that the feature is going to be used exclusively in GitHub. Additionally we add some logging in order to help debug the gitInfo() function
evans
force-pushed
the
evans/fix-remoteUrl
branch
from
6282caa to
1f3f866
Compare
Contributor
Author
|
The |
evans
changed the title
Contributor
Author
|
The azure pipelines fail with an unrelated error:
|
trevor-scheer
approved these changes
Mar 15, 2019
|
|
||
| export const gitInfo = async (): Promise<GitContext | undefined> => { | ||
| export const gitInfo = async ( | ||
| log: Command["log"] |
Contributor
There was a problem hiding this comment.
Might want the type of log to be something a bit more generic, since we're passing in console.log for testing.
Paraphrasing and best guessing, but something like this?
logger: (...args: string[]) => void
This is a non-blocking comment.
Contributor
Author
There was a problem hiding this comment.
hmm they seem to have the same sort of signature log(message?: string, ...args: any[]): void; and I think we want to know when the types of the Command.log become incompatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remoteUrl can no longer be the slug, since we can't assume that the
feature is going to be used exclusively in GitHub and create an accurate
link the frontend. Additionally we add some logging in order to help
debug.
TODO: