Strip leading empty lines in flow generated code#1127
Merged
trevor-scheer merged 4 commits intoapollographql:masterfrom Mar 19, 2019
Merged
Strip leading empty lines in flow generated code#1127trevor-scheer merged 4 commits intoapollographql:masterfrom
trevor-scheer merged 4 commits intoapollographql:masterfrom
Conversation
added 3 commits
March 18, 2019 14:52
trevor-scheer
approved these changes
Mar 19, 2019
Contributor
trevor-scheer
left a comment
trevor-scheer
left a comment
There was a problem hiding this comment.
LGTM, thanks @ganemone! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates apollo-codegen-flow to strip leading empty lines in flow generated code. This is required to ensure the generated code passes lint, since eslint will only be disabled for all the code after the
/* eslint-disable */comment.