UI-309 Update output for service:checks plan error#1178
UI-309 Update output for service:checks plan error#1178justinanastos merged 6 commits intomasterfrom
Conversation
This will also allow us to determine the validation task name before we define the tasks so we don't have to change the task name after we start running. This required changing whitespace on many lines; review this commit with whitespace turned off.
| // anything if we throw. | ||
| Object.assign(taskOutput, ctx); | ||
|
|
||
| task.title = `Validated local schema against tag ${chalk.blue( |
There was a problem hiding this comment.
I think this is still valuable for the tense change
We could refactor the functions that generate the messages out and then unit test them. I think we'd be better served spending a few hours to put together e2e tests. I think if we treat this like JavaScript that we can test all the output with relative ease! |
We were calculating it when the task started running before; that was unncessary because we have all the information we need at load time.
For some reason Listr will show a few items more than once. This is not a regression.
justinanastos
force-pushed
the
justin/service-check/current-plan-error
branch
from
90b7ea1 to
ccded7c
Compare
|
@evans I updated the tense change like you requested; that's the only change. |
evans
left a comment
evans
left a comment
There was a problem hiding this comment.
Noice! Let's ship it
I agree with your assessment that end-2-end tests would be valuable. Do you think that it's worth tracking as a ticket in Jira?
I sure do |
2 participants
Also fixes pluralization in the Listr status messages.
All errors thrown will cause Listr to look strange. I was unable to quickly diagnose where the error originates. It exists in prod also so I didn't try too hard to fix it.
TODO: