Skip to content

Various fixes for Windows#1213

Merged
JakeDawkins merged 12 commits intomasterfrom
jake/fix-vscode-win
May 13, 2019
Merged

Various fixes for Windows#1213
JakeDawkins merged 12 commits intomasterfrom
jake/fix-vscode-win

Conversation

@JakeDawkins
Copy link
Copy Markdown
Contributor

@JakeDawkins JakeDawkins commented Apr 27, 2019

Fixes:

Summary: essentially there were 2 main issues

  1. URIs weren't consistent. URI formats on windows varied between 3 or 4 different formats, and we weren't normalizing them to make sure we handled them all the same. I added a util where I saw breaks to handle them.
  2. Line breaks on windows are 2 characters and we were only assuming 1 in checks inside the onHover handler, so some points on the line weren't being considered part of the token you were hovering over.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins JakeDawkins added the 🗒️ component - vscode related to editor tooling label Apr 27, 2019
@JakeDawkins
Copy link
Copy Markdown
Contributor Author

@berrylaw still a work in progress. Right now, vscode on windows won't properly load because of an issue with matching paths. This fixes that (there's no GH issue for that one). There's also an onHover issue I need to look into before I can merge this

@dylanwulf
Copy link
Copy Markdown

Is this going to include a fix for #1167 ? Or is that something different?

@JakeDawkins
Copy link
Copy Markdown
Contributor Author

@dylanwulf I believe these changes will fix #1167 but I can't confirm quite yet. I'm taking a look today and trying to wrap this up

@JakeDawkins JakeDawkins marked this pull request as ready for review May 13, 2019 20:45
@JakeDawkins JakeDawkins merged commit a3efd20 into master May 13, 2019
@JakeDawkins JakeDawkins deleted the jake/fix-vscode-win branch May 13, 2019 21:11
@JakeDawkins
Copy link
Copy Markdown
Contributor Author

These changes were released in Apollo VS Code 1.6.9

@dylanwulf
Copy link
Copy Markdown

@JakeDawkins Thank you! Just tried it out. The as-you-type autocomplete seems to be working correctly now, but ctrl+space is showing incorrect results. Should I make a new issue for that?

@JakeDawkins
Copy link
Copy Markdown
Contributor Author

JakeDawkins commented May 15, 2019

@dylanwulf Great! We're getting closer 🤞

I'll just leave #1167 open for now and add a note until I can figure out what's going on there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗒️ component - vscode related to editor tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants