Skip to content

Import Foundation in codegen #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
designatednerd merged 2 commits into from
Oct 9, 2019
Merged

Import Foundation in codegen #1248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d02fd62
Import Foundation in codegen
dfed May 8, 2019
1d30068
fix link in changelog
designatednerd Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- `apollo-codegen-swift`
- Ensure fields named `self` don't cause compilation errors in the generated code [#1533](https://github.com/apollographql/apollo-tooling/pull/1533)
- Preserve leading/trailing underscores on field names [#1533](https://github.com/apollographql/apollo-tooling/pull/1533)
- Allow generated code to be compiled without a module umbrella header [#1248](https://github.com/apollographql/apollo-tooling/pull/1248)
- `apollo-codegen-typescript`
- <First `apollo-codegen-typescript` related entry goes here>
- `apollo-env`
Expand Down
1 change: 1 addition & 0 deletions packages/apollo-codegen-swift/src/codeGeneration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ export class SwiftAPIGenerator extends SwiftGenerator<CompilerContext> {
);
this.printNewline();
this.printOnNewline(swift`import Apollo`);
this.printOnNewline(swift`import Foundation`);
}

/**
Expand Down
2 changes: 2 additions & 0 deletions packages/apollo/src/commands/client/__tests__/__snapshots__/generate.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ exports[`client:codegen writes swift types from local schema 1`] = `
"// This file was automatically generated and should not be edited.

import Apollo
import Foundation

public final class SimpleQueryQuery: GraphQLQuery {
/// The raw GraphQL definition of this operation.
Expand Down Expand Up @@ -223,6 +224,7 @@ exports[`client:codegen writes swift types from local schema in a graphql file 1
"// This file was automatically generated and should not be edited.

import Apollo
import Foundation

public final class SimpleQueryQuery: GraphQLQuery {
/// The raw GraphQL definition of this operation.
Expand Down
⚡