Skip to content

Fix logging to the correct operations variable#1289

Merged
trevor-scheer merged 1 commit intomasterfrom
trevor/fix-runtime-logging-error
May 21, 2019
Merged

Fix logging to the correct operations variable#1289
trevor-scheer merged 1 commit intomasterfrom
trevor/fix-runtime-logging-error

Conversation

@trevor-scheer
Copy link
Copy Markdown
Contributor

Recent logging introduced a runtime error for client:push by attempting to log an undefined variable. This PR simply logs the correct variable as was previously intended.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@trevor-scheer trevor-scheer merged commit dbc3fd9 into master May 21, 2019
@abernix
Copy link
Copy Markdown
Member

abernix commented May 21, 2019

I approve this retroactively.

@abernix
Copy link
Copy Markdown
Member

abernix commented May 21, 2019

Follows up #1273. (Linking for posterity)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants