language server: allow template literal placeholders that span multiple rows.#1299
Merged
trevor-scheer merged 2 commits intoapollographql:masterfrom May 30, 2019
Merged
Conversation
…ceholders that span multiple rows
* typo * implicit any * unused imports * file name (+ 1 unrelated, but adjacent) * changelog
trevor-scheer
force-pushed
the
multiline-placeholder
branch
from
62a3910 to
96955ff
Compare
Contributor
|
@henryqdineen, very much appreciated - and thanks for the tests! I pushed a little cleanup to the branch to save you some minor nits. Going to merge as soon as the tests pass 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1298
The fix is just to update the regex to handle newlines in a template literal placeholder. I think this code would be more robust if it used ASTs to extract the graphql documents but I'm assuming there was a reason to use regexes instead.
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.