Skip to content

buildSchemaFromSDL - support meta fields on abstract types#1330

Merged
trevor-scheer merged 2 commits intomasterfrom
trevor/fix-resolveType
Jun 12, 2019
Merged

buildSchemaFromSDL - support meta fields on abstract types#1330
trevor-scheer merged 2 commits intomasterfrom
trevor/fix-resolveType

Conversation

@trevor-scheer
Copy link
Copy Markdown
Contributor

@trevor-scheer trevor-scheer commented Jun 8, 2019

Add support for meta resolvers on abstract types.

Fixes: apollographql/apollo-server#2781

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@trevor-scheer trevor-scheer force-pushed the trevor/fix-resolveType branch from e7b12c6 to 99d06d2 Compare June 9, 2019 03:02
@trevor-scheer trevor-scheer merged commit 25838b6 into master Jun 12, 2019
@trevor-scheer trevor-scheer deleted the trevor/fix-resolveType branch June 12, 2019 00:53
@Pruxis
Copy link
Copy Markdown

Pruxis commented Jun 12, 2019

Thanks for this @trevor-scheer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Federation] __resolveType is not executed

3 participants