Skip to content

Remove federation warnings and update types#1332

Merged
trevor-scheer merged 6 commits intomasterfrom
caydie/remove-warnings
Jun 9, 2019
Merged

Remove federation warnings and update types#1332
trevor-scheer merged 6 commits intomasterfrom
caydie/remove-warnings

Conversation

@trevor-scheer
Copy link
Copy Markdown
Contributor

@trevor-scheer trevor-scheer commented Jun 9, 2019

Thanks to @caydie-tran for handing this off to me. LGTM!

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@trevor-scheer trevor-scheer requested a review from caydie-tran June 9, 2019 02:47
@trevor-scheer trevor-scheer force-pushed the caydie/remove-warnings branch from d9a0ce6 to 8401124 Compare June 9, 2019 02:50
@trevor-scheer trevor-scheer merged commit 01ed358 into master Jun 9, 2019
@trevor-scheer trevor-scheer deleted the caydie/remove-warnings branch June 9, 2019 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants