Skip to content

Add enum renaming ability to federated services.#1344

Closed
JacksonKearl wants to merge 2 commits intomasterfrom
jackson/enum-renaming-in-federated-services
Closed

Add enum renaming ability to federated services.#1344
JacksonKearl wants to merge 2 commits intomasterfrom
jackson/enum-renaming-in-federated-services

Conversation

@JacksonKearl
Copy link
Copy Markdown

@JacksonKearl JacksonKearl commented Jun 12, 2019

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JacksonKearl
Copy link
Copy Markdown
Author

I question if the entire addResolversToSchema function isn't just a half-baked reimplementation of https://github.com/apollographql/graphql-tools/blob/master/src/generate/addResolveFunctionsToSchema.ts in graphql-tools. In particular my hacky implementation of renaming enums seems to be more thoughtfully implemented in https://github.com/apollographql/graphql-tools/blob/master/src/transforms/ConvertEnumValues.ts. Thoughts on if we should be pulling in graphql-tools and using its implementation?

@JacksonKearl
Copy link
Copy Markdown
Author

Superseded by #1345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant