Add enum renaming ability to federated services.#1344
Closed
JacksonKearl wants to merge 2 commits intomasterfrom
Closed
Add enum renaming ability to federated services.#1344JacksonKearl wants to merge 2 commits intomasterfrom
JacksonKearl wants to merge 2 commits intomasterfrom
Conversation
Author
|
I question if the entire addResolversToSchema function isn't just a half-baked reimplementation of https://github.com/apollographql/graphql-tools/blob/master/src/generate/addResolveFunctionsToSchema.ts in graphql-tools. In particular my hacky implementation of renaming enums seems to be more thoughtfully implemented in https://github.com/apollographql/graphql-tools/blob/master/src/transforms/ConvertEnumValues.ts. Thoughts on if we should be pulling in |
4 tasks
Author
|
Superseded by #1345 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.