Fix bug causing completion handlers to sometimes return old results#1361
Merged
JacksonKearl merged 2 commits intomasterfrom Jun 24, 2019
Merged
Fix bug causing completion handlers to sometimes return old results#1361JacksonKearl merged 2 commits intomasterfrom
JacksonKearl merged 2 commits intomasterfrom
Conversation
trevor-scheer
approved these changes
Jun 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the debouncer was configured as
trailing, which meant that the firstn-1calls in a batch ofncalls would get old data, and the last one would get new data.Practically speaking, this meant that a new call for completion items would give the results of the last call for completion items, and a user could only get updated completion items after calling for them twice, more than 400ms apart.
This fixes that by setting the debouncer to be
leading, which means that the first call in a new batch executes, and the remaining calls in the batch get it's results.TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.