Skip to content

Fix service:list snapshot relative time#1374

Merged
justinanastos merged 2 commits intomasterfrom
justin/fix-relative-time-snapshot-failure
Jul 3, 2019
Merged

Fix service:list snapshot relative time#1374
justinanastos merged 2 commits intomasterfrom
justin/fix-relative-time-snapshot-failure

Conversation

@justinanastos
Copy link
Copy Markdown
Contributor

The time is relative; over time the value changes, causing the snapshot to
fail.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

The time is relative; over time the value changes, causing the snapshot to
fail.
@justinanastos justinanastos requested a review from JakeDawkins July 3, 2019 15:12
@justinanastos justinanastos merged commit 5e1e44f into master Jul 3, 2019
@justinanastos justinanastos deleted the justin/fix-relative-time-snapshot-failure branch July 3, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants