Skip to content

add header to service list #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayakoneval merged 5 commits into from
Jul 9, 2019
Merged

add header to service list #1377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cfc3f2b
add header to service list
mayakoneval Jul 5, 2019
4cf3d02
changelog
mayakoneval Jul 5, 2019
03f7046
lowercase labels as is standard in apollo-tooling (i think)
mayakoneval Jul 5, 2019
afaaa67
update service list test snapshot
mayakoneval Jul 5, 2019
a752dbe
sort alphabetically
mayakoneval Jul 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

- `apollo`
- Relax graphql version, resolve missing types "Boolean", "String" [#1355](https://github.com/apollographql/apollo-tooling/pull/1355)
- Add `service:list` and tests [#1358](https://github.com/apollographql/apollo-tooling/pull/1358)
- Add `service:list` and tests [#1358](https://github.com/apollographql/apollo-tooling/pull/1358) and header [#1377](https://github.com/apollographql/apollo-tooling/pull/1377)
- Update `service:list` test to use a simulated time to prevent relative dates causing snapshot failures [#1374](https://github.com/apollographql/apollo-tooling/pull/1374)
- `apollo-codegen-core`
- <First `apollo-codegen-core` related entry goes here>
Expand Down
2 changes: 2 additions & 0 deletions packages/apollo/src/commands/service/__tests__/__snapshots__/list.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ Loading Apollo Project [completed]
Fetching list of services for graph engine [started]
Fetching list of services for graph engine [completed]

name URL last updated
───────── ───────────────────────────── ─────────────────────────
accounts http://localhost:4001/graphql 13 May 2019 (a month ago)
inventory http://localhost:4002/graphql 16 May 2019 (a month ago)
products http://localhost:4003/graphql 16 May 2019 (a month ago)
Expand Down
9 changes: 5 additions & 4 deletions packages/apollo/src/commands/service/list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,15 +67,16 @@ function formatHumanReadable({
process.env.NODE_ENV === "test" ? new Date("2019-06-13") : undefined
)
)
.sort((s1, s2) =>
s1.name.toUpperCase() > s2.name.toUpperCase() ? 1 : -1
)
.filter(Boolean),
{
columns: [
{ key: "name", label: "Name" },
{ key: "name", label: "name" },
{ key: "url", label: "URL" },
{ key: "updatedAt", label: "Last Updated At" }
{ key: "updatedAt", label: "last updated" }
],
// Override `printHeader` so we don't print a header
printHeader: () => {},
// The default `printLine` will output to the console; we want to capture the output so we can test
// it.
printLine: line => {
Expand Down
⚡