Support --json and --markdown for federated schema:check#1378
Conversation
|
@jgzuke: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
| // Add a cosmetic line break | ||
| console.log(""); | ||
|
|
||
| cli.table(compositionErrors, { |
There was a problem hiding this comment.
Just curious, does the heroku table and the cli table display tables differently?
There was a problem hiding this comment.
Not sure! I havent seen the output of heroku table. This was moved from https://github.com/apollographql/apollo-tooling/pull/1378/files#diff-c61805bdfe85787383d4ae9927bd0774L567 to keep the non json/markdown behavior the same
| } | ||
|
|
||
| if (!serviceName) { | ||
| const graphName = config.service && config.service.name; |
There was a problem hiding this comment.
NBD: This might be a nice place for a comment explaining the naming conventions as a result of federation / the mismatch between this and the gateway!
3 participants
Support
--markdownand--jsonflags forapollo schema:checkcommand. Reintroduce tests and update snapshots.Also refactor
check.tsslightly, including renamingserviceNametographNamein markdown output now that there is a more pronounced difference between the terms with federation.TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.