[airbnb] Update Swift codegen to add operation name to generated query classes#1386
Merged
trevor-scheer merged 3 commits intoapollographql:masterfrom Jul 15, 2019
Merged
Conversation
Contributor
|
@skevy Looks like there's a few tests and/or their sample code which need to be updated |
Contributor
Author
|
Whoops! This is what I get for doing this so late at night. Will do. Sorry about that! |
skevy
force-pushed
the
skevy--add-operation-name
branch
from
53b50c5 to
7ba9e9f
Compare
skevy
force-pushed
the
skevy--add-operation-name
branch
from
7ba9e9f to
3abd28f
Compare
Contributor
designatednerd
left a comment
designatednerd
left a comment
There was a problem hiding this comment.
Swift LGTM, would appreciate a look from someone who knows typescript!
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Swift codegen to add the operation name to generated query classes.
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.